Remove libgomp.so link when building for TBB only. #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with `NO_TBB=OFF` and `NO_OMP=ON` the `osd_cpu_obj` objects target will be configured to link to `gomp`. When OpenMP is disabled, the omp-specific files (`ompEvaluator` and `ompKernel`) are not actually built, and therefore the link is not needed. Although this doesn't create problems in opensubdiv builds, downstream projects may face challenges as the link carries over through cmake to any project that links to opensubdiv. Signed-off-by: Niall Lenihan <[email protected]>
Member
|
Filed as internal issue #OSD-475 |
Member
|
@nlenihan-wetafx Could you submit a Contributor License Agreement Thank you! |
Author
|
Hi @davidgyu - that is all sent through. Talking to some people here, we are unsure if WētāFX has an existing corporate CLA in place. Let me know if I need to get someone here to send that through as well. Thank you! |
Author
|
We are getting the corporate CLA reviewed and signed at the moment as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with
NO_TBB=OFFandNO_OMP=ONtheosd_cpu_objobjects target will be configured to link togomp.When OpenMP is disabled, the omp-specific files (
ompEvaluatorandompKernel) are not actually built, and therefore the link is not needed.Although this doesn't create problems in opensubdiv builds, downstream projects may face challenges as the link carries over through cmake to any project that links to opensubdiv.