Simplify bool -> int conversion in GfNumericCast

nvidia-jomiller · nvidia-jomiller · commit be75edf23ec7 · 2025-10-21T15:59:45.000-07:00
diff --git a/pxr/base/gf/numericCast.h b/pxr/base/gf/numericCast.h
@@ -103,7 +103,7 @@ GfNumericCast(From from, GfNumericCastFailureType *failType = nullptr)
     // bool -> int
     if constexpr (std::is_same_v<From, bool> && std::is_integral_v<To>) {
         // No need to range check bool to int
-        return from ? static_cast<To>(1) : static_cast<To>(0);
+        return To{from};
     }
     // int -> bool
     else if constexpr (std::is_integral_v<From> && std::is_same_v<To, bool>) {

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ GfNumericCast(From from, GfNumericCastFailureType *failType = nullptr)`
`103`	`103`	`// bool -> int`
`104`	`104`	`if constexpr (std::is_same_v<From, bool> && std::is_integral_v<To>) {`
`105`	`105`	`// No need to range check bool to int`
`106`		`- return from ? static_cast<To>(1) : static_cast<To>(0);`
	`106`	`+ return To{from};`
`107`	`107`	`}`
`108`	`108`	`// int -> bool`
`109`	`109`	`else if constexpr (std::is_integral_v<From> && std::is_same_v<To, bool>) {`