Skip to content

Duplicated fragment code in BasisCurves.glslfx #3132

@PierreWang

Description

@PierreWang

Description of Issue

In change 56e3997, some common shading code are moved to terminals.glslfx. But he forgot to remove the corresponding snippets in BasisCurves.Fragment of BasisCurves.glslfx. And then in the following change, the removed snippets for Curves.Fragment.Wire is incorrectly returned back at change b3e6fee.

So now, ApplyColorOverrides and LightingBlend are firstly called in the Curves.Fragment.Wire and Curves.Fragment.Patch shader code, and then called again in the ShadingTerminal code. This should be a duplication.

We have created a PR 3124 for this issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions