Autodesk: Vulkan Bugfix - HgiVulkanBlitCmds offset #3382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion offset Source offset of a cpu-to-gpu-copy defines the offset of the source cpu memory, and the destination offset of a cpu-to-gpu-copy defines the offset of the destination gpu buffer. The `memcpy`` from the cpu memory to the staging buffer should use the source offset and the destination offset respectively. But the copy from the staging buffer to the gpu buffer should use the destination offset to define `VkBufferCopy.srcOffset`.
Collaborator
|
Filed as internal issue #USD-10365 |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
clach
merged commit b3303a2
into
PixarAnimationStudios:feature-hgi-vulkan
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
feature-hgi-vulkan.The staged copy of HgiVulkanBlitCmds has incorrect source and destination offset,
Source offset of a cpu-to-gpu-copy defines the offset of the source cpu memory, and the destination offset of a cpu-to-gpu-copy defines the offset of the destination gpu buffer.
The
memcpyfrom the cpu memory to the staging buffer should use the source offset and the destination offset respectively. But the copy from the staging buffer to the gpu buffer should use the destination offset to defineVkBufferCopy.srcOffset.Link to proposal (if applicable)
N/A
Fixes Issue(s)
N/A
Checklist
[ ] I have created this PR based on the dev branch
[X] I have followed the coding conventions
[ ] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[X] I have verified that all unit tests pass with the proposed changes
[X] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)