work: account for task_group_base interface change in oneTBB 2022.0.0 #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The m_wait_ctx member being used in a narrow band of oneTBB versions was removed in a refactor that went into the most recent release: uxlfoundation/oneTBB@1f52f50 This change accounts for the update in the new version of oneTBB and uses the newly added m_wait_vertex member to access the same context as before.
Collaborator
|
Filed as internal issue #USD-10388 |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Fixes #3445. |
Contributor
|
Thanks for this. It works for me as a downstream patch in Fedora’s |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
m_wait_ctxmember being used in a narrow band of oneTBB versions was removed in a refactor that went into version v2022.0.0 which was released yesterday:uxlfoundation/oneTBB@1f52f50
This change accounts for the update in the new version of oneTBB and uses the newly added
m_wait_vertexmember to access the same context as before.I am far from an expert in the TBB API or the intricacies of this area of libwork, but wanted to offer this up as it allowed me to successfully build OpenUSD against the latest version of oneTBB. I have not done any performance profiling with the new oneTBB version.
Checklist
[x] I have created this PR based on the dev branch
[x] I have followed the coding conventions
[ ] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[x] I have verified that all unit tests pass with the proposed changes
[x] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)