Skip to content

Bolt receiver support patch #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

spoutn1k
Copy link

@spoutn1k spoutn1k commented May 28, 2024

I am creating this PR on behalf of @xinix00 in issue #402.

This patch fixes an issue where connecting to a device through the bolt receiver failed. This patch fixes issue #402, #388 and #385. Multiple people have been affected and have been helped by that fix. Hope this can be applied to all.

@mcmcghee
Copy link

@PixlOne any chance on getting this merged?

@filintodelgado
Copy link

I really hope this gets merged soon, It is really annoying having to turn off and back on every time

@ankon
Copy link

ankon commented Jan 6, 2025

I guess the problem here is that the patch looks wrong: The lock is supposed to protect modifications to the _waiters, and on the surface it does do that -- all places touching _waiters now first acquire that lock.

This smells like the mutex here should be reentrant (i.e. be a std::recursive_mutex and not just std::mutex), but I don't know the code base well enough to see the path that would require that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants