-
Notifications
You must be signed in to change notification settings - Fork 26
Add all known outstanding yaml config options as of process-compose v1.7.3 #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…1.7.3
- per-process `description` that displays in the UI
- global and per-process `log_configuration`, including `rotation`
- global and per-process `vars` for supporting Go template expansion on configs
- `env_cmds` allows running host commands to populate env variables
- `ordered_shutdown` controls the order of process shutdown
- `is_strict` does additional checking on configuration files at startup
- `disable_env_expansion` to not propagate .env variables to processes
- `http_get.{headers,status_code}` and `working_dir` for probe commands
- `replicas` to run multiple copies of processes
- `entrypoint` alternate to `command`
- `is_elevated` for sudo/runas priviledged processes
- `extends,is_disabled,is_dotenv_disabled` for multi-file fragments and overrides.
- `launch_timeout_seconds` for daemon processes
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@shivaraj-bh Does this look good to be merged? |
adrian-gierakowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also add all env vars from here to here:
process-compose-flake/nix/process-compose/cli.nix
Lines 18 to 27 in e968a94
| environment = mkOption { | |
| default = { }; | |
| description = "Environment variables to pass to process-compose binary."; | |
| type = types.submodule { | |
| options = { | |
| PC_DISABLE_TUI = mkOption { | |
| type = types.nullOr types.bool; | |
| default = null; | |
| description = "Disable the TUI (Text User Interface) of process-compose"; | |
| }; |
adrian-gierakowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are also some missing flags here, like disable-dotenv
|
I want to use the options defined in this PR. Aside from 3 comments from @adrian-gierakowski and a small nit (about |
|
@daroot Would you like to address these, so we can merge your PR? |
- Make disable-dotenv default to true, per @adrian-gierakowski request. - Remove unnecessary args in vars.nix
|
I've updated the missing env vars and addressing the args nit. I'm less sure about adding all the individual cli options separately. Given you can do |
@daroot It might seems like a rather strange use-case, but: I often use these settings to enforce certain cli options on the users of the app. For example, |
These are not very crucial (as one can still use CLI args). Can be added later if needed |
descriptionthat displays in the UIlog_configuration, includingrotationvarsfor supporting Go template expansion on configsenv_cmdsallows running host commands to populate env variablesordered_shutdowncontrols the order of process shutdownis_strictdoes additional checking on configuration files at startupdisable_env_expansionto not propagate .env variables to processeshttp_get.{headers,status_code}andworking_dirfor probe commandsreplicasto run multiple copies of processesentrypointalternate tocommandis_elevatedfor sudo/runas priviledged processesextends,is_disabled,is_dotenv_disabledfor multi-file fragments and overrides.launch_timeout_secondsfor daemon processes