Skip to content

Comments

recovery key sent to ocs#5

Open
nguironnet wants to merge 3 commits intoPluginsOCSInventory-NG:masterfrom
nguironnet:more-fonctionnality-get-recovery-key
Open

recovery key sent to ocs#5
nguironnet wants to merge 3 commits intoPluginsOCSInventory-NG:masterfrom
nguironnet:more-fonctionnality-get-recovery-key

Conversation

@nguironnet
Copy link

Add the recoverykey and protectors type to ocs

Add the recoverykey and protectors type
@gillesdubois
Copy link
Member

Hi @nguironnet ,

We will take a look at your issue soon.

However, could you please keep Stephane PAUTREL in Author.
Even if you made a lot of changes in the VBS, he is still the original developer.

Of course, you can add a second line with your name if you want to be credited for the VBS file :)

Regards,
Gilles.

@nguironnet
Copy link
Author

Hi @nguironnet ,

We will take a look at your issue soon.

However, could you please keep Stephane PAUTREL in Author.
Even if you made a lot of changes in the VBS, he is still the original developer.

Of course, you can add a second line with your name if you want to be credited for the VBS file :)

Regards,
Gilles.

Yes, you're rigth. It's corrected

@gillesdubois
Copy link
Member

Hi @nguironnet

Thanks for your contribution, I saw that you added a new commit (c6659cc)
Is your PR ready or do you want me to wait a few days before testing it ?

Regards,
Gilles.

@nguironnet
Copy link
Author

Hi @nguironnet

Thanks for your contribution, I saw that you added a new commit (c6659cc)
Is your PR ready or do you want me to wait a few days before testing it ?

Regards,
Gilles.

Yes, please wait 1 week more, i'm testing it on my network

@nguironnet
Copy link
Author

It's ok, you can test it.
It works like i want

@Neustradamus
Copy link

Dear @OCSInventory-NG team, @gillesdubois, @kapouik, @damienbelliard, @paullepetit, @RudyLaurent, @charleneauger, @Atineon,

I wish you a Happy New Year 2025!

Have you progressed on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants