Use image base __ImageBase directly for module handle#12
Open
RatinCN wants to merge 1 commit into
Open
Conversation
Replace GetModuleHandleA and the stored hInst value with the linker-provided __ImageBase symbol. This removes the import, the local hInstance slot, and the global hInst storage while still passing the module base to RegisterClass/CreateWindowEx and the Go To dialog. Measured with the local build: trpad.obj drops from 14911 to 14852 bytes (-59), and the Crinkler output drops from 2794 to 2783 bytes (-11).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
GetModuleHandleAand the stored hInst value with the linker-provided__ImageBasesymbol.Measured with the local build:
Also reduced 7 lines code.