Feat: add filter additional data synthese for module monitoring #3663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3663 +/- ##
===========================================
- Coverage 84.56% 84.23% -0.33%
===========================================
Files 133 133
Lines 10320 10367 +47
===========================================
+ Hits 8727 8733 +6
- Misses 1593 1634 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andriacap
force-pushed
the
feat/add-filter-additional-data-synthese
branch
2 times, most recently
from
04d4f37 to
4e370ad
Compare
- Call function from gn_module_monitoring to enrich monitoring config in order to get fiedls to filter - Add subgroup in form object in order to target filters for monitoring Reviewed-by: @andriacap
- Use config parameters "show_additional_filters" in order to display or not advanced filters monitorings Reviewed-by: @andriacap
- need to adapt code in frontend and backend to use new config structure (object with protocol keys) Reviewed-by: andriac
- Transform object date in order to compare with string date format - Transform list concatenated data with ',' in json field additional_data to use contain fonction Reviewed-by: acapai
Reviewed-by: acapai
andriacap
force-pushed
the
feat/add-filter-additional-data-synthese
branch
from
4e370ad to
e4820d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR propose de pouvoir filtrer sur le champ "additional_data" des observations liées aux protocoles du module monitoring.
Voir détail sur l'issue #3662 .