Skip to content

Conversation

@jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Oct 13, 2025

This PR propose to :

  • use the Taxref tree to filter Synthese results when one or multiple cd_ref_parent are given
  • add the possibility as discussed in Améliorer la recherche par taxon dans la synthèse #3707 to filter by taxa and their children (if the user want it) directly using the taxon seach form. A checkbox under the taxon search formular was proposed

This is not definitive, this PR is still a work in progress

TODO

  • Search field in the Synthese still only search through taxons observed in GN
  • A checkbox below the form indicate if the user wishes to fetch also children taxon

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.53%. Comparing base (23e7e0a) to head (569c7c6).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...nature/core/gn_synthese/utils/query_select_sqla.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3763      +/-   ##
===========================================
+ Coverage    84.48%   84.53%   +0.04%     
===========================================
  Files          133      133              
  Lines        10361    10357       -4     
===========================================
+ Hits          8754     8755       +1     
+ Misses        1607     1602       -5     
Flag Coverage Δ
pytest 84.53% <62.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants