Skip to content

[FIX][Map] Exclure les points hors limites de l'affichage de la carte #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[FIX][Map] Exclure les points hors limites de l'affichage de la carte #3772

wants to merge 1 commit into from
+11 −1

Conversation

@VincentCauchois
Copy link
Member

@VincentCauchois VincentCauchois commented Oct 23, 2025

Limites mondiales :

  • Latitudes : -90 à 90
  • Longitudes : -180 à 180

Comportement retenu :

  • Tout point hors des limites est exclu du GeoJSON rendu, mais reste présent dans la liste
    • N'entraîne alors qu'une notification d'avertissement au clic et pas de changement de zoom notamment
  • Si la couche finale ne contient aucun point, le zoom est fixé sur la bounding box correspondant aux limites mondiales

@VincentCauchois
fix(map.component.ts): limit map bounds to world limits
e36046d 
Useful when synthese data happens to be out of world limits.

Synthese data for which position is out of world limits are not added in Leaflet geoJSON layer.
Moreover, when all data happens to be thus removed, the map is centered on world limits.
@VincentCauchois VincentCauchois self-assigned this Oct 23, 2025
@VincentCauchois VincentCauchois added bug frontend javascript Pull requests that update Javascript code labels Oct 23, 2025
@VincentCauchois VincentCauchois changed the title [FIX][Map] Exclure de l'affichage dans la carte les points hors limites [FIX][Map] Exclure de l'affichage de la carte les points hors limites Oct 23, 2025
@VincentCauchois VincentCauchois changed the title [FIX][Map] Exclure de l'affichage de la carte les points hors limites [FIX][Map] Exclure les points hors limites de l'affichage de la carte Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.50%. Comparing base (088858f) to head (e36046d).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3772      +/-   ##
===========================================
+ Coverage    84.48%   84.50%   +0.01%     
===========================================
  Files          133      133              
  Lines        10361    10361              
===========================================
+ Hits          8754     8756       +2     
+ Misses        1607     1605       -2
Flag Coverage Δ
pytest 84.50% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacquesfize jacquesfize Awaiting requested review from jacquesfize

@christophe-ramet christophe-ramet Awaiting requested review from christophe-ramet

Assignees

@VincentCauchois VincentCauchois

Labels

bug frontend javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VincentCauchois