fix(braze-content-proxy): replace shortUrl with regular URL #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Get Ten Tabs a.k.a. Pocket Hits to populate with stories.
When Pocket Parser was turned off on Dec 10, the
shortUrlfield stopped being resolved in the federated GraphQL schema. The braze-content-proxy was filtering out items whereshortUrlwas null (line 40 of scheduledItems.ts), which removed all items from the response, causing Braze to receive an empty array and preventing stories from populating in the Pocket Hits email.Fix
Removed the
shortUrlfield from the GraphQL query and the null filter, while still emittingshortUrlin the response by setting it equal to the regularurlfield for backwards compatibility with the Braze template.