Add symlink directory for easy log access#217
Open
Bruce1102 wants to merge 4 commits intoPoint72:mainfrom
Open
Add symlink directory for easy log access#217Bruce1102 wants to merge 4 commits intoPoint72:mainfrom
Bruce1102 wants to merge 4 commits intoPoint72:mainfrom
Conversation
Signed-off-by: Bruce Lau <bruce.lau@cubistsystematic.com>
- Add type hints for *args/**kwargs to comply with style guide - Narrow exception handling to OSError/PermissionError - Fix test to let FileHandler create log file naturally - Add tests for actual log writing and symlink updates - Remove double exception logging between init and helper method Signed-off-by: Bruce Lau <bruce.lau@cubistsystematic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 84.84% 84.88% +0.03%
==========================================
Files 126 128 +2
Lines 11891 11987 +96
Branches 1194 1196 +2
==========================================
+ Hits 10089 10175 +86
- Misses 1448 1456 +8
- Partials 354 356 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates flat directory with symlinks to Hydra's timestamped logs for easier tailing, searching, and monitoring.
Example:
Changes
Notes: