-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add lumiose city pokedex and new megas #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legends Z-A was released. I hope it brings us joy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legends Z-A is released, so it means it can be approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WyattC16 Your support means much more to me.
|
Can I ask where this data was sourced from? We can make edits if things are wrong, but I'd prefer to be closer to 95%-99% correct the first time. |
For the most part, I used some JavaScript to scrape the data off of serebii.net. Below is a summary of how each file was updated.
Here are the two pages I pulled from. The available Pokémon was used to populate pokemon_dex_numbers.csv. The rest of the of the files were populated from the Mega Evolutions page.
Below is the JavaScript I used. |
|
Thanks for the incredibly thorough response, adds a lot of confidence this information is correct. Especially because you automated the larger files! I am happy to approve and ship this. |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
|
Hi! I deployed in the production env, can you check if the data is present? |
add lumiose city pokedex and new megas