[WIP] Tweet view #106
Open
[WIP] Tweet view #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweets will appear in a slider, user can swipe left/right for seeing tweets.
Change tweet slide badge color to Twitter's brand color Reduce font size for tweet ids issue #68
WoH
reviewed
Oct 10, 2016
|
|
||
| @Input() pokemon: Pokemon; | ||
|
|
||
| tweetArray: Object[]; |
|
|
||
| // We will get timestamps from the api, here is a function for converting | ||
| // http://stackoverflow.com/questions/847185/convert-a-unix-timestamp-to-time-in-javascript | ||
| timestampToDate(timestamp) |
|
|
||
| export class PokeTweetsComponent { | ||
|
|
||
| @Input() pokemon: Pokemon; |
There was a problem hiding this comment.
If you just need the name, just pass the name
| @Component({ | ||
| template: require('./poke-tweets.component.html'), | ||
| styles: [require('./poke-tweets.component.scss')], | ||
| selector: 'poke-tweets' |
There was a problem hiding this comment.
selector should be first
| /* Mock data */ | ||
| this.tweetArray = []; | ||
| for(var i = 0; i < 20; i++) { | ||
| var tweet = { |
There was a problem hiding this comment.
use const instead of var
| "id": 12345 + i, | ||
| "text": "Lorem ipsum dolor sit amet, " + this.pokemon.name + " adipiscing elit", | ||
| "coordinates": [0, 0], | ||
| "timestamp": this.timestampToDate((Date.now() / 1000) + i | 0) |
There was a problem hiding this comment.
Property names should be unquoted. Strings should use single quotes
| var seconds = "0" + date.getSeconds(); | ||
|
|
||
| // Will display time in 10:30:23 format | ||
| var formattedTime = hours + ':' + minutes.substr(-2) + ':' + seconds.substr(-2); |
| ngOnInit() { | ||
| /* Mock data */ | ||
| this.tweetArray = []; | ||
| for(var i = 0; i < 20; i++) { |
There was a problem hiding this comment.
Use let instead of var
|
Thanks for the comments @MajorBreakfast @WoH . This is a work in progress so I just put that code to mock the api. The code in the |
|
This PR is ancient, and the last commit as well |
|
fyi see #68 |
|
@AlexanderLill yup.. equally old :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue Implement Tweet-View #68
This tweets component could be used for the mob card issue #80
Work In Progress
Right now, works with randomly generated data.
TODO: Get data from the API