Skip to content

Adds human backgrounds #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

lolman360
Copy link

Description of changes

Adds human homeworlds, citizenships, languages, religions etc.

Why and what will this PR improve

Fleshing out the background system with Polaris' lore.

Authorship

All contained lore is wholly written by the Polaris loreteam. They're pretty cool guys.

Changelog

🆑
add: Added human homeworlds, citizenships, languages and religions.
/:cl:

@lolman360
Copy link
Author

definitely want someone to look over word wrapping/etc once this is done

@lolman360 lolman360 marked this pull request as ready for review March 30, 2025 01:10
Copy link

@Cerebulon Cerebulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only issues I can see, mostly just minor spelling things!

I think for Vatborn it may be possible to just add/remove specific items rather than re-init the entire list but the way this is implemented for e.g. Unathi is a little fucked so it may be safest just to do what you did anyway.

subversive_potential = 0.8


/decl/background_detail/faction/contractor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, this is probably more sensible than listing every corporation individually unless we do anything else with the datums later. Good thinking.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't take credit for it, this is how it was on the etherpad

colour = ""
key = "2"
partial_understanding = list("Galactic Common" = 40, "Solar Common" = 20, "Terminus" = 40, "Gutter" = 10, "Sivian Creole" = 10)
//, LANGUAGE_SKRELLIAN = 40, LANGUAGE_SKRELLIANFAR = 15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galcom should also have the Skrellian bits, I take it these values are from old code?

Is there an issue with including Skrellian being "not found" due to it being in another modpack? We may have to define our own version of Skrellspeak in the polaris modpack if that's the case, but that's an issue for a Skrell PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...I kind of forgot they were in-game already, I'll add them in

key = "3"
space_chance = 45
partial_understanding = list("Galactic Common" = 20, "Solar Common" = 20, "Tradeband" = 10, "Terminus" = 20, "Sivian Creole" = 15)
//LANGUAGE_SKRELLIAN = 15, LANGUAGE_SIIK = 10) also

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, Catlanguage should already exist but is it inaccessible due to being in another modpack currently?

distance = "21.6 ly"


//New Seoul goes here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a complete stub but this should probably be here as a location even if it's not in as a culture, since "locations" are used for some other random generation and New Seoul is fairly important politically
https://ss13polaris.com/index.php?title=New_Seoul

@Cerebulon
Copy link

I can't find the exact cause in the web view but one of the "/decl/background_category/heritage = list(" lines in overrides.dm is also causing an identation check fail, may need to check for extra spaces etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants