feat: add matricole intro#111
Conversation
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
WalkthroughThis PR introduces a new ChangesMatricole Page Feature
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/matricole/intro.tsx (1)
29-46: ⚡ Quick winClarify whether ResourceCard should link to destination pages.
The cards display action-oriented descriptions ("Controlla i risultati...", "Tutte le informazioni..."), but currently render as static display components. Header navigation has corresponding items ("Rankings", "Tol Project") pointing to placeholder hrefs, and no destination routes exist yet. Consider either: (1) wrapping cards with links once routes are implemented, or (2) clarifying if these should remain informational only.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/matricole/intro.tsx` around lines 29 - 46, ResourceCard is currently a static display but uses action-oriented copy; decide whether it should navigate or stay informational and implement accordingly: add an optional href?: string to ResourceCardProps and, inside ResourceCard, conditionally wrap the Glass component with a Next.js <Link> (or an <a> for non-Next projects) when href is provided, preserving className and accessibility (use role/aria as needed, target/rel for external links); alternatively, if you intend it to remain informational, update the copy passed to title/description to remove imperative phrasing. Update all callers of ResourceCard to pass href when navigation is desired (e.g., for "Rankings" / "Tol Project") or change the copy where no route exists.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/matricole/intro.tsx`:
- Around line 48-123: The MatricoleBackground component currently uses a fixed
viewport-width-dependent height (h-[248.3218vw]) and hardcoded style percentages
(e.g., left: "-26.0417%", left: "66.7244%", top: "-10.1142%") which break
responsiveness; update MatricoleBackground to use responsive sizing (replace
h-[248.3218vw] and the inline percentage style values with Tailwind responsive
utilities like sm:, md:, lg: variants or switch to CSS variables/clamp() or
media-query-driven classes), adjust the Image wrapper positioning to provide
alternative values per breakpoint (for the two Image instances and the two
positioned looper containers), and verify visually across mobile/tablet/desktop
to ensure the background scales as intended without overflowing layout.
---
Nitpick comments:
In `@src/components/matricole/intro.tsx`:
- Around line 29-46: ResourceCard is currently a static display but uses
action-oriented copy; decide whether it should navigate or stay informational
and implement accordingly: add an optional href?: string to ResourceCardProps
and, inside ResourceCard, conditionally wrap the Glass component with a Next.js
<Link> (or an <a> for non-Next projects) when href is provided, preserving
className and accessibility (use role/aria as needed, target/rel for external
links); alternatively, if you intend it to remain informational, update the copy
passed to title/description to remove imperative phrasing. Update all callers of
ResourceCard to pass href when navigation is desired (e.g., for "Rankings" /
"Tol Project") or change the copy where no route exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 23ca5553-f7d3-441b-ba0a-1f7eb129c707
📒 Files selected for processing (4)
src/app/matricole/page.tsxsrc/components/header/constants.tssrc/components/home/hero.tsxsrc/components/matricole/intro.tsx
fixes #95