Aligned PR and push workflows to use identical test commands for consistency #6473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude Claude Code configuration files from version control 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The .claude directory should be a local configuration directory for Claude Code, not a git submodule. It is now properly ignored via .gitignore. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
hua7450
force-pushed
the
this-better-works
branch
from
726676e to
f30d0d2
Compare
MaxGhenis
requested changes
Aug 29, 2025
Contributor
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
can you make these common actions their own files and bring them in? modularity will further ensure consistency
Collaborator
Author
The main issue we have is the coverage check in github action. There are two ways to fix it.
Option 2: Use venv but fix coverage
|
Contributor
|
I mean reusing workflows across push and pr actions, see https://github.com/PolicyEngine/policyengine-us-data/tree/main/.github/workflows |
The uv sync --dev command wasn't properly installing dev dependencies. Now using uv sync --all-extras and explicitly installing coverage and pytest. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Implemented virtual environment approach with coverage fixes: - Use uv sync --all-extras for dependency installation - Set COVERAGE_FILE environment variable to ensure consistent data location - Add --data-file=.coverage flag to all coverage commands - Configure coverage settings in pyproject.toml for consistency - Handle coverage combine gracefully in case of no parallel files This approach maintains better memory isolation through virtual environments while ensuring coverage data is properly collected and combined. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The coverage collection wasn't working because test_batched.py spawns subprocesses that don't inherit coverage tracking. This commit: - Extracts test and coverage logic into a reusable workflow - Properly configures coverage collection for each test batch - Ensures coverage files are combined and reported correctly The direct coverage test (test_coverage_direct.sh) proves that coverage collection works when tests are run directly with coverage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
hua7450
force-pushed
the
this-better-works
branch
from
2430640 to
6c0ab6e
Compare
Collaborator
Author
|
Superseded by #6474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
Fixes GitHub Actions test failures and aligns PR and push workflows to ensure consistent test execution. If PR tests pass, push tests will also pass - eliminating post-merge surprises.
🔧 Key Changes
1️⃣ Fixed Coverage Module Error
uv run coverageresulted in "command not found" errorsuv run python -m coveragefor proper module execution.github/workflows/pr.yaml,.github/workflows/push.yaml2️⃣ Unified Test Execution
Both PR and push workflows now run identical test commands:
3️⃣ Fixed Dependency Installation
uv sync --devtouv sync --all-extrasuv pip install coverage pytestto ensure test tools are availablepytest>=8.3.0to dev dependencies inpyproject.toml4️⃣ Python Version Update
📝 Files Modified
.github/workflows/pr.yaml- PR workflow test commands.github/workflows/push.yaml- Push workflow test commandspyproject.toml- Added pytest to dev dependencieschangelog_entry.yaml- Documented changes🔍 Command Changes
✅ Benefits