Skip to content

Conversation

@anth-volk
Copy link
Contributor

@anth-volk anth-volk commented Jan 6, 2026

Summary

Adds label metadata to 8 ParameterScale parameters that had no labels. This enables automatic label generation for their 68 bracket child parameters (e.g., [0].rate, [1].threshold) in the PolicyEngine API.

Parameters updated

Scale Parameter Label Added
gov.irs.credits.education.american_opportunity_credit.amount American Opportunity Credit marginal rate schedule
gov.irs.credits.eitc.phase_out.joint_bonus EITC joint filer bonus phase-out start
gov.irs.credits.premium_tax_credit.eligibility Premium Tax Credit eligibility thresholds
gov.irs.credits.premium_tax_credit.phase_out.ending_rate Premium Tax Credit phase-out ending rate
gov.irs.credits.premium_tax_credit.phase_out.starting_rate Premium Tax Credit phase-out starting rate
gov.states.dc.tax.income.credits.ptc.fraction_elderly DC property tax credit offset fraction (elderly)
gov.states.dc.tax.income.credits.ptc.fraction_nonelderly DC property tax credit offset fraction (non-elderly)
gov.states.dc.tax.income.rates DC income tax rates

Test plan

  • Verify parameter labels are correctly generated in the API for bracket children
  • Confirm no breaking changes to existing functionality

Fixes #7115

🤖 Generated with Claude Code

Added label metadata to 8 ParameterScale parameters that had no labels,
enabling automatic label generation for their bracket child parameters.

Parameters updated:
- gov.irs.credits.education.american_opportunity_credit.amount
- gov.irs.credits.eitc.phase_out.joint_bonus
- gov.irs.credits.premium_tax_credit.eligibility
- gov.irs.credits.premium_tax_credit.phase_out.ending_rate
- gov.irs.credits.premium_tax_credit.phase_out.starting_rate
- gov.states.dc.tax.income.credits.ptc.fraction_elderly
- gov.states.dc.tax.income.credits.ptc.fraction_nonelderly
- gov.states.dc.tax.income.rates

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@anth-volk anth-volk force-pushed the fix/add-labels-to-brackets branch from 27124f9 to ce3c26a Compare January 6, 2026 15:25
@anth-volk anth-volk marked this pull request as ready for review January 6, 2026 15:32
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.77%. Comparing base (fc2b613) to head (ce3c26a).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main    #7116       +/-   ##
============================================
- Coverage   100.00%   76.77%   -23.23%     
============================================
  Files           10     3649     +3639     
  Lines          144    52526    +52382     
  Branches         0      263      +263     
============================================
+ Hits           144    40328    +40184     
- Misses           0    12172    +12172     
- Partials         0       26       +26     
Flag Coverage Δ
unittests 76.77% <ø> (-23.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add labels to scale params that don't have them

2 participants