⬆️ Upgrade to Polkadot SDK stable2412-2

[dastansam]

What?

closes #446

Tasks

• Review release notes for stable2412 for breaking changes. Also check the release notes of the versions before (with a focus on stable2409 and 1.14.0).
• Update Polkadot SDK dependencies to stable2412.
• Update ORML dependencies to the according version.
• Test node and runtime compatibility (e.g., compile-time errors, runtime APIs, storage migrations).
• Audit custom pallets for deprecated or changed SDK interfaces.
• Update benchmarks (if applicable) for weight calculations.

Additional Context

• The Treasury::propose_spend(...) integrations tests needs a rework, since that extrinsic is now deprecated, and it should be replaced by Treasury::sped_local(...). We can ignore these tests for now and re-add them in a later PR.

Why?

Release analysis posts here.

Some notable PRs:

• Replaces SignedExtra with new TransactionExtension. This requires us to reimplement the custom CheckNonce as a follow up PR - FRAME: Reintroduce TransactionExtension as a replacement for SignedExtension paritytech/polkadot-sdk#3685
• XCM V5 is now latest, so v4 xcm types are replaced with v5 - XCM v5 paritytech/polkadot-sdk#4826 -
• merges xcm-fee-payment-runtime-api module into the new xcm-runtime-apis - [xcm] runtime api for LocationToAccount conversions paritytech/polkadot-sdk#4857
• remove sp-std dependency, replace with alloc or core

How?

Testing?

• Pallet Unit Testing (e.g. cargo t -p pallet-funding)
• Integration Tests (e.g. cargo t -p integration-tests)
• Try Runtime CLI, to test if we have to run any migration in this upgrade.

Screenshots (optional)

Syncing with mainnet `polimec`

[dastansam]

• 🏗️ Vesting pallet block number provider migration #474 : 2 dependent PRs (#476 , #478 )
• 🏗️ Linear release block number provider migration #473
• 🏗️ Funding pallet migration for enabling async backing #472
• ✨ Prepare pallets for async backing #471
• ⬆️ Upgrade to Polkadot SDK stable2412-2 #470 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[lrazovic]

A few minor nits, but overall looks quite good! I'm just a bit worried about this entire XCMv5, maybe a bit "premature" since AH is still not using it. Do you think it is a good idea to proceed with the update? Can we stick to XCMv4 for now and move to v5 after AH also migrates to v5?

[Copilot]

Pull Request Overview

This PR upgrades dependencies to the stable2412-2 release and updates related interfaces and APIs across pallets, nodes, and integration tests. Key changes include:

• Replacing deprecated APIs (e.g. sp_std, treasury extrinsics) with their new counterparts.
• Updating transaction extension, xcm, and runtime API usages to align with the latest versions.
• Upgrading various dependency versions in the Cargo.toml files to ensure compatibility with the new release.

Reviewed Changes

Copilot reviewed 92 out of 93 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pallets/democracy/src/benchmarking.rs	Replaced sp_std::borrow::Cow with alloc::borrow::Cow
pallets/democracy/Cargo.toml	Removed sp-std dependency from std configuration
nodes/parachain/src/service.rs	Updated executor config and transaction pool builder usage
nodes/parachain/src/rpc.rs	Removed DenyUnsafe property in RPC extensions
nodes/parachain/src/command.rs	Updated RPC addressing signature and hwbench function call
nodes/parachain/src/chain_spec/*	Replaced legacy account seed methods with sp_keyring alternatives
nodes/parachain/Cargo.toml	Added sp-keyring workspace dependency and runtime bench updates
integration-tests/src/tests/*	Switched from get_account_id_from_seed to get_public_from_string_or_panic and updated xcm & transaction extension APIs
integration-tests/Cargo.toml	Upgraded dependencies, replacing xcm-fee-payment-runtime-api with xcm-runtime-apis
Cargo.toml	Upgraded substrate-wasm-builder, orml dependencies, jsonrpsee and other Substrate components

Files not reviewed (1)

• justfile: Language not supported

Comments suppressed due to low confidence (11)

nodes/parachain/src/service.rs:126

• Confirm that wrapping the transaction pool builder result with Arc::from is intended instead of directly using the builder's build() result; verify that the type conversion is compatible with downstream usage.

let transaction_pool = Arc::from(

nodes/parachain/src/service.rs:235

• Review the updated generic parameters in the aura::run invocation to ensure they match the expected signature for the new version of the API.

let fut = aura::run::<Block, sp_consensus_aura::sr25519::AuthorityPair, _, _, _, _, _, _, _, _>(params);

nodes/parachain/src/rpc.rs:22

• Confirm that the removal of the deny_unsafe usage in RPC extensions does not compromise the security of RPC calls; ensure that the new approach meets security requirements.

pub use sc_rpc::DenyUnsafe;

nodes/parachain/src/command.rs:320

• Ensure that the updated RPC address signature (returning a vector of endpoints) is correctly handled by all downstream consumers.

fn rpc_addr(&self, default_listen_port: u16) -> Result<Option<Vec<sc_cli::RpcEndpoint>>> {

integration-tests/src/tests/transaction_payment.rs:130

• Double-check the new transaction extension API calls (validate and prepare) to ensure they correctly handle fee calculation and error propagation as expected by the updated runtime.

let (_, val, _) = signed_extension.validate(...).expect("tx extension validation failed");

integration-tests/src/tests/runtime_apis.rs:15

• Verify that changing the parameter from 4u32 to 5u32 for the acceptable payment assets query is deliberate and aligns with the new runtime expectations.

let accepted_payment_assets = PolimecRuntime::query_acceptable_payment_assets(5u32).unwrap();

integration-tests/src/tests/governance.rs:238

• Reminder: Uncomment and update the treasury proposal test once the treasury API changes are resolved to maintain comprehensive test coverage.

/// TODO: uncomment later and fix

integration-tests/src/tests/governance.rs:289

• Ensure that the test for slashed treasury proposal funds is revisited and re-enabled with appropriate modifications once the treasury API update is fully integrated.

/// TODO: same here

integration-tests/Cargo.toml:81

• Confirm that replacing xcm-fee-payment-runtime-api with xcm-runtime-apis is consistent across the codebase and does not introduce any compatibility issues.

xcm-runtime-apis.workspace = true

Cargo.toml:54

• Review the upgraded substrate-wasm-builder version to ensure that it is fully compatible with the runtime build and does not introduce unexpected behavior.

substrate-wasm-builder = { version = "25.0.0" }

Cargo.toml:74

• Ensure that upgrading orml-oracle to version 1.3.0 is compatible with the current SDK interfaces and that any breaking changes have been addressed.

orml-oracle = { version = "1.3.0", default-features = false }

[dastansam]

moved back to xcm::v4 following fellowship upgrade

[lrazovic]

Merge activity

• May 2, 7:23 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• May 2, 7:23 AM EDT: @lrazovic merged this pull request with Graphite.