feat(milestone): delivery milestone one - papi simulator#1
feat(milestone): delivery milestone one - papi simulator#1oshakarishvili merged 2 commits intoPolkadot-Fast-Grants:masterfrom
Conversation
|
Hi @developerfred - I'm trying to run through your milestone 1 submission but it seems that the major issue is that components aren't rendering in the browser: In addition, the |
|
A couple things I noticed in my review:
Other than that, looks good to me!
|
Thanks for pointing I will fix the kusama descriptor and improve the way to display the autocomplete when the preview is open |
hey @sacha-l fix here: developerfred/papi-simulator#25 its possible check on: https://papi-simulator.aipop.fun |
|
I think the z-index issue is still there, have you tested it in different browsers and screen sizes? Once that's fixed please do me a favor and update the milestone delivery submission template to the new one here (just to include your DOT address for issuing the payment): https://github.com/Polkadot-Fast-Grants/delivery/blob/master/deliveries/milestone-delivery-template.md |
|
@sacha-l Okay, I’m going to do a test today on different screens and mainstream browsers I’ll update PR adding my address, thank you. |
|
Hey @developerfred - no need to make a new PR, you can just add it in a commit here with this format: ed3530d 🙏🏻 |
|
Thanks @sacha-l @platonicsocrates, I'm absolutely thrilled about the forthcoming AYE from the curators @FlavioPolimec @dimdomsum @oshakarishvili |
oshakarishvili
left a comment
There was a problem hiding this comment.
Everything looks good on my end. Child bounty has been approved, and the payout has been issued: https://polkadot.subsquare.io/treasury/child-bounties/4108
Thanks! |
2922d88
into
Polkadot-Fast-Grants:master
KeyPass milestone 1 delivery
created and updated deliverable file




📬 Milestone Delivery Checklist
Link to the application pull request: Polkadot-Fast-Grants/apply#4 < please fill this in with the PR number of your application.