Skip to content

feat(milestone): delivery milestone one - papi simulator#1

Merged
oshakarishvili merged 2 commits intoPolkadot-Fast-Grants:masterfrom
aipop-fun:master
May 19, 2025
Merged

feat(milestone): delivery milestone one - papi simulator#1
oshakarishvili merged 2 commits intoPolkadot-Fast-Grants:masterfrom
aipop-fun:master

Conversation

@developerfred
Copy link

📬 Milestone Delivery Checklist

  • The delivery template has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • The milestone was completed within 3 months of approval.
  • The milestone is complete (no partial deliveries).
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • The delivery is according to the delivery guidelines.
  • I understand that the milestone will be evaluated within 14 days, and if changes are needed, I will have one opportunity to fix and resubmit within 14 days.

Link to the application pull request: Polkadot-Fast-Grants/apply#4 < please fill this in with the PR number of your application.

@sacha-l
Copy link
Collaborator

sacha-l commented Apr 29, 2025

Hi @developerfred - I'm trying to run through your milestone 1 submission but it seems that the major issue is that components aren't rendering in the browser:
Screenshot 2025-04-29 at 19 24 04

In addition, the Module not found: Can't resolve '@polkadot-api/descriptors' keeps coming up when I npm run dev in a local copy of the repo. Please fix these so that I can run through your TESTING.md file and see things working as expected.

@developerfred
Copy link
Author

developerfred commented Apr 30, 2025

In addition, the Module not found: Can't resolve '@polkadot-api/descriptors' keeps coming up when I npm run dev in a local copy of the repo. Please fix these so that I can run through your TESTING.md file and see things working as expected.

@sacha-l

The first example does not have a component, so it does not appear.
In feature select -> example it is possible to check a react component called "dashboard component"

I added a print

Screenshot 2025-04-30 at 04 39 17

About the descriptors I will update and upload all the descriptors to vercel and update 'TESTING.md'

@developerfred
Copy link
Author

developerfred commented Apr 30, 2025

@sacha-l
Copy link
Collaborator

sacha-l commented May 5, 2025

A couple things I noticed in my review:

  • For 1B. React Component Preview Panel: the autocompletion panel gets truncated by the preview panel (see screenshot)
  • For 1E: Update Blockchain descriptors job fails with an error about kusama being the wrong name, should be ksmcc3 or something

Other than that, looks good to me!

Screenshot 2025-05-05 at 16 43 10

@developerfred
Copy link
Author

A couple things I noticed in my review:

  • For 1B. React Component Preview Panel: the autocompletion panel gets truncated by the preview panel (see screenshot)

  • For 1E: Update Blockchain descriptors job fails with an error about kusama being the wrong name, should be ksmcc3 or something

Other than that, looks good to me!

Screenshot 2025-05-05 at 16 43 10

Thanks for pointing

I will fix the kusama descriptor and improve the way to display the autocomplete when the preview is open

@developerfred
Copy link
Author

A couple things I noticed in my review:

  • For 1B. React Component Preview Panel: the autocompletion panel gets truncated by the preview panel (see screenshot)
  • For 1E: Update Blockchain descriptors job fails with an error about kusama being the wrong name, should be ksmcc3 or something

Other than that, looks good to me!
Screenshot 2025-05-05 at 16 43 10

Thanks for pointing

I will fix the kusama descriptor and improve the way to display the autocomplete when the preview is open

hey @sacha-l fix here: developerfred/papi-simulator#25

its possible check on: https://papi-simulator.aipop.fun

@sacha-l
Copy link
Collaborator

sacha-l commented May 8, 2025

I think the z-index issue is still there, have you tested it in different browsers and screen sizes? Once that's fixed please do me a favor and update the milestone delivery submission template to the new one here (just to include your DOT address for issuing the payment): https://github.com/Polkadot-Fast-Grants/delivery/blob/master/deliveries/milestone-delivery-template.md

@developerfred
Copy link
Author

developerfred commented May 8, 2025

@sacha-l Okay, I’m going to do a test today on different screens and mainstream browsers

I’ll update PR adding my address, thank you.

@sacha-l
Copy link
Collaborator

sacha-l commented May 8, 2025

Hey @developerfred - no need to make a new PR, you can just add it in a commit here with this format: ed3530d 🙏🏻

@developerfred
Copy link
Author

developerfred commented May 8, 2025

@sacha-l done here 00008dd

Copy link
Collaborator

@sacha-l sacha-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@developerfred
Copy link
Author

Thanks @sacha-l @platonicsocrates, I'm absolutely thrilled about the forthcoming AYE from the curators @FlavioPolimec @dimdomsum @oshakarishvili

Copy link

@oshakarishvili oshakarishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good on my end. Child bounty has been approved, and the payout has been issued: https://polkadot.subsquare.io/treasury/child-bounties/4108

@developerfred
Copy link
Author

Everything looks good on my end. Child bounty has been approved, and the payout has been issued: https://polkadot.subsquare.io/treasury/child-bounties/4108

Thanks!

@oshakarishvili oshakarishvili merged commit 2922d88 into Polkadot-Fast-Grants:master May 19, 2025
1 of 2 checks passed
oshakarishvili pushed a commit that referenced this pull request Jun 29, 2025
oshakarishvili pushed a commit that referenced this pull request Nov 6, 2025
created and updated deliverable file
@FFilipUnique FFilipUnique mentioned this pull request Dec 15, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants