fix: adversarial review findings — 10 issues caught

REGRESSIONS FIXED:
- Polymarket.__init__: remove private key validation from init (breaks
  read-only CLI usage). Move validation to _init_api_keys() where it's
  actually needed for trading operations.
- build_order(): restore py_order_utils imports (Signer, OrderBuilder,
  OrderData) that were accidentally removed.

BUGS FIXED:
- TradingAgent.weekly(): call self.schedule.weekly() instead of
  self.weekly() — method is on TimeScheduler, not TradingScheduler
- parse_pydantic_market: filter None from parse_nested_event results
  to prevent None entries in market.events list
- get_usdc_balance: fix 10e5 -> 10**6 (USDC has 6 decimals, was off
  by 10x)
- Source.id/name: add = None defaults (required in Pydantic v2)
- tenacity retry: add httpx.TimeoutException and httpx.NetworkError
  to retry exception types (httpx doesn't raise Python TimeoutError)
- _init_approvals: replace 6 remaining print() with logger.info()
- executor.py get_polymarket_llm: replace last print() with logger

Author: TheophilusChinomona

agents/application/creator.py

@@ -1,3 +1,4 @@
+import httpx
 import logging
 
 from tenacity import retry, stop_after_attempt, wait_exponential, retry_if_exception_type
@@ -20,7 +21,13 @@ def __init__(self):
     @retry(
         stop=stop_after_attempt(MAX_RETRIES),
         wait=wait_exponential(multiplier=1, min=2, max=30),
-        retry=retry_if_exception_type((ConnectionError, TimeoutError, RuntimeError)),
+        retry=retry_if_exception_type((
+            ConnectionError,
+            TimeoutError,
+            RuntimeError,
+            httpx.TimeoutException,
+            httpx.NetworkError,
+        )),
         reraise=True,
     )
     def one_best_market(self):

agents/application/cron.py

@@ -24,4 +24,4 @@ def start(self) -> None:
 class TradingAgent(TradingScheduler):
     def __init__(self) -> None:
         super().__init__()
-        self.weekly(Monday(), self.trader.one_best_trade)
+        self.schedule.weekly(Monday(), self.trader.one_best_trade)

agents/application/executor.py

@@ -100,7 +100,7 @@ def get_polymarket_llm(self, user_input: str) -> str:
         else:
             # If exceeding limit, process in chunks
             chunk_size = len(combined_data) // ((total_tokens // token_limit) + 1)
-            print(f'total tokens {total_tokens} exceeding llm capacity, now will split and answer')
+            logger.info('total tokens %d exceeding llm capacity, now will split and answer', total_tokens)
             group_size = (total_tokens // token_limit) + 1 # 3 is safe factor
             keys_no_meaning = ['image','pagerDutyNotificationEnabled','resolvedBy','endDate','clobTokenIds','negRiskMarketID','conditionId','updatedAt','startDate']
             useful_keys = ['id','questionID','description','liquidity','clobTokenIds','outcomes','outcomePrices','volume','startDate','endDate','question','questionID','events']

agents/application/trade.py

@@ -1,6 +1,7 @@
 import logging
 import shutil
 
+import httpx
 from tenacity import retry, stop_after_attempt, wait_exponential, retry_if_exception_type
 
 from agents.application.executor import Executor as Agent
@@ -33,7 +34,13 @@ def clear_local_dbs(self) -> None:
     @retry(
         stop=stop_after_attempt(MAX_RETRIES),
         wait=wait_exponential(multiplier=1, min=2, max=30),
-        retry=retry_if_exception_type((ConnectionError, TimeoutError, RuntimeError)),
+        retry=retry_if_exception_type((
+            ConnectionError,
+            TimeoutError,
+            RuntimeError,
+            httpx.TimeoutException,
+            httpx.NetworkError,
+        )),
         reraise=True,
     )
     def one_best_trade(self) -> None:

agents/polymarket/gamma.py

@@ -28,7 +28,9 @@ def parse_pydantic_market(self, market_object: dict) -> Market:
             if "events" in market_object:
                 events: list[PolymarketEvent] = []
                 for market_event_obj in market_object["events"]:
-                    events.append(self.parse_nested_event(market_event_obj))
+                    parsed = self.parse_nested_event(market_event_obj)
+                    if parsed is not None:
+                        events.append(parsed)
                 market_object["events"] = events
 
             # These two fields below are returned as stringified lists from the api

agents/polymarket/polymarket.py

@@ -20,6 +20,9 @@
     OrderBookSummary,
 )
 from py_clob_client.order_builder.constants import BUY
+from py_order_utils.builders import OrderBuilder
+from py_order_utils.model import OrderData
+from py_order_utils.signer import Signer
 
 from agents.utils.objects import SimpleMarket, SimpleEvent
 
@@ -41,10 +44,6 @@ def __init__(self) -> None:
 
         self.chain_id = 137  # POLYGON
         self.private_key = os.getenv("POLYGON_WALLET_PRIVATE_KEY")
-        if not self.private_key:
-            raise ValueError(
-                "POLYGON_WALLET_PRIVATE_KEY environment variable is required"
-            )
 
         self.polygon_rpc = "https://polygon-rpc.com"
         self.w3 = Web3(Web3.HTTPProvider(self.polygon_rpc))
@@ -72,12 +71,15 @@ def __init__(self) -> None:
         self._init_approvals(False)
 
     def _init_api_keys(self) -> None:
+        if not self.private_key:
+            raise ValueError(
+                "POLYGON_WALLET_PRIVATE_KEY is required for trading operations"
+            )
         self.client = ClobClient(
             self.clob_url, key=self.private_key, chain_id=self.chain_id
         )
         self.credentials = self.client.create_or_derive_api_creds()
         self.client.set_api_creds(self.credentials)
-        # print(self.credentials)
 
     def _init_approvals(self, run: bool = False) -> None:
         if not run:
@@ -104,7 +106,7 @@ def _init_approvals(self, run: bool = False) -> None:
         usdc_approve_tx_receipt = web3.eth.wait_for_transaction_receipt(
             send_usdc_approve_tx, 600
         )
-        print(usdc_approve_tx_receipt)
+        logger.info("USDC approve receipt (CTF Exchange): %s", usdc_approve_tx_receipt)
 
         nonce = web3.eth.get_transaction_count(pub_key)
 
@@ -120,7 +122,7 @@ def _init_approvals(self, run: bool = False) -> None:
         ctf_approval_tx_receipt = web3.eth.wait_for_transaction_receipt(
             send_ctf_approval_tx, 600
         )
-        print(ctf_approval_tx_receipt)
+        logger.info("CTF approval receipt: %s", ctf_approval_tx_receipt)
 
         nonce = web3.eth.get_transaction_count(pub_key)
 
@@ -137,7 +139,7 @@ def _init_approvals(self, run: bool = False) -> None:
         usdc_approve_tx_receipt = web3.eth.wait_for_transaction_receipt(
             send_usdc_approve_tx, 600
         )
-        print(usdc_approve_tx_receipt)
+        logger.info("USDC approve receipt (Neg Risk CTF): %s", usdc_approve_tx_receipt)
 
         nonce = web3.eth.get_transaction_count(pub_key)
 
@@ -153,7 +155,7 @@ def _init_approvals(self, run: bool = False) -> None:
         ctf_approval_tx_receipt = web3.eth.wait_for_transaction_receipt(
             send_ctf_approval_tx, 600
         )
-        print(ctf_approval_tx_receipt)
+        logger.info("CTF approval receipt (Neg Risk): %s", ctf_approval_tx_receipt)
 
         nonce = web3.eth.get_transaction_count(pub_key)
 
@@ -170,7 +172,7 @@ def _init_approvals(self, run: bool = False) -> None:
         usdc_approve_tx_receipt = web3.eth.wait_for_transaction_receipt(
             send_usdc_approve_tx, 600
         )
-        print(usdc_approve_tx_receipt)
+        logger.info("USDC approve receipt (Neg Risk Adapter): %s", usdc_approve_tx_receipt)
 
         nonce = web3.eth.get_transaction_count(pub_key)
 
@@ -186,7 +188,7 @@ def _init_approvals(self, run: bool = False) -> None:
         ctf_approval_tx_receipt = web3.eth.wait_for_transaction_receipt(
             send_ctf_approval_tx, 600
         )
-        print(ctf_approval_tx_receipt)
+        logger.info("CTF approval receipt (Neg Risk Adapter): %s", ctf_approval_tx_receipt)
 
     def get_all_markets(self) -> "list[SimpleMarket]":
         markets = []
@@ -353,7 +355,7 @@ def get_usdc_balance(self) -> float:
         balance_res = self.usdc.functions.balanceOf(
             self.get_address_for_private_key()
         ).call()
-        return float(balance_res / 10e5)
+        return float(balance_res / 10**6)
 
 
 def test():

agents/utils/objects.py

@@ -212,8 +212,8 @@ class SimpleEvent(BaseModel):
 
 
 class Source(BaseModel):
-    id: Optional[str]
-    name: Optional[str]
+    id: Optional[str] = None
+    name: Optional[str] = None
 
 
 class Article(BaseModel):