Skip to content

Conversation

@RafalZgoda
Copy link

Summary
Remove console logging from the SDK error handler while keeping the current return based error shape.

Changes

  • Delete all console.error calls in src/http-helpers/index.ts
  • Keep returning { error, status } or the original error payload when present
  • No API or behavior change for consumers

Why

  • A SDK should not log to stdout by default
  • Let the consuming app decide how and where to log
  • Cleaner output in server and browser environments

@RafalZgoda RafalZgoda requested a review from a team as a code owner October 11, 2025 17:41
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Console Error Logging Not Removed

A console.error call remains at line 113 in the error handler, which was intended to be removed as part of the PR's goal to delete all console.error calls. This means the SDK still logs to stdout in one error path, contradicting the intended change to remove all SDK logging.

src/http-helpers/index.ts#L112-L113

console.error("[CLOB Client] request error", err);

Fix in Cursor Fix in Web


@yog4a
Copy link

yog4a commented Dec 11, 2025

This is the worst codebase I’ve ever seen, the SDK is a complete nightmare. And the console errors… you can’t disable them, no debug flag, nothing when creating the clob client. That’s next-level stupidity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants