Skip to content

Conversation

@Fleuveroi
Copy link

@Fleuveroi Fleuveroi commented Nov 21, 2025

Note

Modernizes TypeScript config: NodeNext modules, ES2020 target/lib, excludes dist, and streamlines strict options.

  • Build/TypeScript Config (tsconfig.json):
    • Switch module and moduleResolution to NodeNext.
    • Bump target and lib to es2020.
    • Add dist to exclude; simplify exclude entries.
    • Keep strict; remove redundant strictNullChecks/noImplicitReturns; retain noUnused* and noFallthroughCasesInSwitch.
    • Add descriptive comments and minor cleanup.

Written by Cursor Bugbot for commit 03e8364. This will update automatically on new commits. Configure here.

@Fleuveroi Fleuveroi requested a review from a team as a code owner November 21, 2025 19:59
// Removed redundant options already covered by "strict: true":
// - "noImplicitReturns"
// - "strictNullChecks"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect removal of noImplicitReturns option

The comment claims noImplicitReturns is covered by strict: true, but this is incorrect. The strict flag only enables noImplicitAny, noImplicitThis, alwaysStrict, strictBindCallApply, strictNullChecks, strictFunctionTypes, and strictPropertyInitialization. It does not include noImplicitReturns, which must be enabled separately. Removing this option weakens type checking by no longer requiring all code paths in functions to return values.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant