Skip to content

Conversation

@JasonLeung1983
Copy link

@JasonLeung1983 JasonLeung1983 commented Nov 21, 2025

Updated TypeScript configuration for improved module resolution and output.


Note

Modernizes TypeScript config: switch to NodeNext modules, target ES2020, clean include/exclude (add dist), and streamline strict options.

  • TypeScript config (tsconfig.json):
    • Module/Resolution: Set module and moduleResolution to NodeNext.
    • Target/Lib: Raise target to es2020 and lib to es2020, dom.
    • Strictness: Keep strict: true; retain noUnusedLocals, noUnusedParameters, noFallthroughCasesInSwitch; remove redundant strict options.
    • Project structure: Add dist to exclude; deduplicate node_modules exclusions; keep include: src/**/*.
    • Output/Interop: Preserve outDir: dist, sourceMap, declaration, esModuleInterop, resolveJsonModule, experimentalDecorators, importHelpers, skipLibCheck, typeRoots.}

Written by Cursor Bugbot for commit b9caab4. This will update automatically on new commits. Configure here.

Updated TypeScript configuration for improved module resolution and output.
@JasonLeung1983 JasonLeung1983 requested a review from a team as a code owner November 21, 2025 21:31
// Removed redundant options already covered by "strict: true":
// - "noImplicitReturns"
// - "strictNullChecks"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect claim about noImplicitReturns coverage

The comment incorrectly states that noImplicitReturns is covered by strict: true, but this is false. The strict flag only enables specific checks like strictNullChecks and noImplicitAny, not noImplicitReturns. Removing this option reduces type safety by allowing functions to have code paths that don't return values when a return type is specified, which was previously caught as an error.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant