Mustafa/bump build #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "lint": "make lint", | ||
| "postbuild": "cp package.json dist && cp README.md dist" | ||
| "postbuild": "cp package.json dist && cp README.md dist", | ||
| "prepublishOnly": "make build" |
There was a problem hiding this comment.
Bug: prepublishOnly skips postbuild, missing files in dist
The new prepublishOnly script runs make build directly, which only executes tsc according to the Makefile. This bypasses npm's lifecycle hooks, so the postbuild script that copies package.json and README.md to the dist folder won't run. The published package will be missing these files. The script could run npm run build instead to trigger the full build chain including postbuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Bumps to 3.0.1 and adds a prepublish build step to the package scripts.
versionto3.0.1inpackage.json.prepublishOnlyscript to runmake buildbefore publishing.scriptsblock formatting.Written by Cursor Bugbot for commit 8b42e60. This will update automatically on new commits. Configure here.