Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I noticed I was placing an order with size 9.53 and I was getting back one with size 9.52.
Turns out it was due to round_down(9.53, 2) = 9.52 in order_builder/helpers.
Description
Types of changes
Status
[WIP]if necessary (changes not yet made).same "Found 108 errors in 10 files (checked 21 source files)" linting errors as py-clob-client 0.25.0.
Note
Replace float-based rounding with Decimal.quantize for base-10 precision and simplify to_token_decimals.
round_down,round_normal,round_upnow useDecimal.quantizewithROUND_FLOOR,ROUND_HALF_UP, andROUND_CEILINGto ensure base-10 precision.to_token_decimalsrewritten to useDecimal.quantizeafter scaling by10**6, removing intermediate float checks.Written by Cursor Bugbot for commit 292d0c3. This will update automatically on new commits. Configure here.