fix: stop filtering NewMarket/MarketResolved WS events by subscribed assets#16
Open
yovanoc wants to merge 1 commit intoPolymarket:mainfrom
Open
fix: stop filtering NewMarket/MarketResolved WS events by subscribed assets#16yovanoc wants to merge 1 commit intoPolymarket:mainfrom
yovanoc wants to merge 1 commit intoPolymarket:mainfrom
Conversation
…assets NewMarket and MarketResolved are broadcast events with new/different asset IDs that will never match the subscriber's asset_ids_set, causing them to be silently dropped. These events should always be yielded to consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewMarket and MarketResolved are broadcast events with new/different asset IDs that will never match the subscriber's asset_ids_set, causing them to be silently dropped. These events should always be yielded to consumers.
Note
Low Risk
Low risk: small change limited to WebSocket message filtering, but it can increase the volume of market-channel events delivered to subscribers.
Overview
Stops filtering
WsMessage::NewMarketandWsMessage::MarketResolvedby the subscriber’sasset_ids_setinsubscription.rs; these event types are now always yielded to market subscribers so they aren’t silently dropped when they reference new/different asset IDs.Reviewed by Cursor Bugbot for commit 9905d4b. Bugbot is set up for automated code reviews on this repo. Configure here.