fix: add explicit serde/strum rename for MAKER_REBATE

[yovanoc]

MakerRebate was deserializing to Unknown("MAKER_REBATE") because rename_all = "UPPERCASE" produces "MAKERREBATE" not "MAKER_REBATE". Added explicit serde/strum rename attributes.

---

Note

Low Risk
Low risk: a small serialization/deserialization mapping fix limited to ActivityType, with no logic or data-flow changes beyond correcting the wire-format string.

Overview
Fixes ActivityType::MakerRebate string mapping by adding explicit serde and strum renames to MAKER_REBATE, ensuring the enum correctly serializes/deserializes this API value instead of falling back to Unknown.

^{Reviewed by Cursor Bugbot for commit f9523b9. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f9523b9. Configure here.}

[cursor]

Wrong rename_all rule invites repeat of same bug

Low Severity

The ActivityType enum uses rename_all = "UPPERCASE", which doesn't insert underscores between words — that's exactly what caused the MakerRebate bug this PR fixes. Using rename_all = "SCREAMING_SNAKE_CASE" (and serialize_all = "SCREAMING_SNAKE_CASE" for strum) would produce identical results for all existing single-word variants while correctly handling multi-word variants automatically. This would eliminate the need for the explicit rename on MakerRebate and prevent any future multi-word variant from silently falling through to Unknown.

Additional Locations (1)

• src/data/types/mod.rs#L51-L53

 

^{Reviewed by Cursor Bugbot for commit f9523b9. Configure here.}