fix(clob): invalidate version and V2 fee caches#19
Open
birchrust wants to merge 1 commit intoPolymarket:mainfrom
Open
fix(clob): invalidate version and V2 fee caches#19birchrust wants to merge 1 commit intoPolymarket:mainfrom
birchrust wants to merge 1 commit intoPolymarket:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
invalidate_internal_caches()so it also clears V2 fee metadata, token-to-condition mapping, and cached protocol version.This prevents order creation from reusing stale V2 fee parameters or an outdated CLOB version after explicit cache invalidation.
Note
Medium Risk
Medium risk because it changes cache invalidation semantics for fee/version resolution, which can alter when extra HTTP calls occur and what fee parameters are used for order sizing.
Overview
Ensures
Client::invalidate_internal_caches()fully resets all CLOB market configuration state by additionally clearing V2 fee metadata (fee_infos), token→condition mappings, and the cached/versionresult (reset to0).Adds a regression test asserting that after invalidation the client re-fetches
versionand re-primes market info via/markets-by-token+/clob-markets, preventing reuse of stale V2 fee parameters.Reviewed by Cursor Bugbot for commit c620131. Bugbot is set up for automated code reviews on this repo. Configure here.