handle empty fee_rate_bps in MakerOrder deserialization#24
Open
christian-git-md wants to merge 1 commit intoPolymarket:mainfrom
Open
handle empty fee_rate_bps in MakerOrder deserialization#24christian-git-md wants to merge 1 commit intoPolymarket:mainfrom
christian-git-md wants to merge 1 commit intoPolymarket:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
Possibly there is an interpretation difference between "intentionally absent" and 0, but I suggest breaking the struct definition for the legacy feature is not worth it.
Note
Low Risk
Low risk: narrowly changes JSON deserialization for
MakerOrder.fee_rate_bpsto tolerate empty strings, plus a unit test; behavioral change could mask upstream API issues but is limited to one field.Overview
Makes
MakerOrder.fee_rate_bpsrobust to the API returning an empty string by deserializing it as0viaempty_string_as_zero.Adds a regression unit test ensuring
MakerOrderdeserialization succeeds whenfee_rate_bpsis"".Reviewed by Cursor Bugbot for commit 1171513. Bugbot is set up for automated code reviews on this repo. Configure here.