Add selectItems and associated tests #437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436
As mentioned in the issue above, this may actually be an
array-selectorissue more than aniron-listissue, but as this specific code seems better managed iniron-listthan in user space code as initially noted with the potential solution in #124, I figured this was a good step in getting this conversation more definitively completed.This code adds a
selectItemsmethod that selects the entirety ofthis.itemswhen no arguments are found, or casts the content of arguments into an Array such that they can be selected in batch regardless of them being an array, a single item, or a list of items.Tests for "select items: all", "select items: array" (sending the method an array), "select items: arguments" (sending the batch as an arguments list), and "select items: single" to maintain this functionality moving forward.