feat: 🎸 create asProposal methods #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sansan
force-pushed
the
feat/DA-1558
branch
3 times, most recently
from
f1a2a94 to
82e2f32
Compare
polymath-eric
previously approved these changes
Nov 19, 2025
|
Contributor
Author
|
/fast-forward |
|
Triggered from #1568 (comment) by @sansan. Trying to fast forward Target branch ( commit 84821b22094c76a67ebe99561627048de3aaa22e (HEAD -> develop, tag: v29.1.0-beta.12, origin/develop)
Author: Toms <[email protected]>
Date: Wed Nov 19 09:32:25 2025 +0200
fix: 🐛 get all exemptionsPull request ( commit b93fd0cb9640b8bf60b8c41a4ec74eb40744a450 (pull_request/feat/DA-1558)
Author: Toms <[email protected]>
Date: Tue Nov 11 15:44:39 2025 +0200
feat: 🎸 create asProposal methodsFast forwarding $ git push origin b93fd0cb9640b8bf60b8c41a4ec74eb40744a450:develop
remote: error: GH006: Protected branch update failed for refs/heads/develop.
remote:
remote: - Waiting on code owner review from PolymeshAssociation/middleware.
To https://github.com/PolymeshAssociation/polymesh-sdk.git
! [remote rejected] b93fd0cb9640b8bf60b8c41a4ec74eb40744a450 -> develop (protected branch hook declined)
error: failed to push some refs to 'https://github.com/PolymeshAssociation/polymesh-sdk.git' |
polymath-eric
approved these changes
Nov 20, 2025
Contributor
|
/fast-forward |
|
🎉 This PR is included in version 29.1.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
asProposalparameter (default:true) togetTotalFees()andtoSignablePayload()methods, allowing flexibility to handle MultiSig transactions as direct transactions rather than proposals.PolymeshTransactionBase.getTotalFees(asProposal = true)asProposal: false, uses the signing account directly for fee calculation (ignores MultiSig payer)asProposal: true(default), maintains existing behavior (uses MultiSig payer if available)PolymeshTransactionBase.toSignablePayload(metadata, asProposal = true)asProposal: false, returns payload withmultiSig: nulland unwrapped transactionasProposal: true(default), maintains existing behavior (includes MultiSig address and wraps as proposal)New helper methods:
composeTxForFees(asProposal: boolean)- Conditionally wraps transaction based onasProposalflaggetBaseTransaction()- Abstract method to get unwrapped transaction (implemented inPolymeshTransactionandPolymeshTransactionBatch)Updated
getPayingAccount(asProposal = true)asProposal: trueJIRA Link
https://polymesh.atlassian.net/browse/DA-1558