Update CMakeLists to modern practices #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern CMake allows target's properties to be imported recursively. This repository was using a combination of CMake targets and explicit path references, which is undesirable. It now uses targets for all dependencies, and the dependencies config is now in a seperate file for manageability. TODO: Testing and update CMake minimum version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern CMake allows target's properties to be imported recursively.
This repository was using a combination of CMake targets and explicit
path references, which is undesirable.
It now uses targets for all dependencies, and the dependencies config
is now in a separate file for manageability.
This has been tested on Debian, CMake 3.7.2
TODO: Further testing and maybe update CMake minimum version.