Open interval #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-kotov
requested changes
May 7, 2025
|
|
||
| d <- Mx |> | ||
| Deaths <- read_table( | ||
| "https://www.prdh.umontreal.ca/BDLC/data/ont/Deaths_5x1.txt", |
There was a problem hiding this comment.
How sustainable is this and all other links to prhd.umontreal.ca ? Could it happen that the data will be gone in, say, 5 years? Or if the university decides to change the link structure? So perhaps we would like to keep the data in the repository?
| library(kableExtra) | ||
| lt_2015 |> | ||
| select(Age = age, x, n, Mx, ax, qx, px, lx, dx, Lx, Tx, ex) |> | ||
| kable(format = "latex", booktabs = T, |
There was a problem hiding this comment.
Why only this specific table is with format='latex? All other tables in this R script are printed with default output.
Also, perhaps, since we are saving figures to plots folder, we should also save tables as PDF or HTML files that can be (1) recreated and (2) viewed when we run the repo in Binder and run this script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following for the period life table example:
kable()function call to create Table 2