pulseaudio: Correct output writing place where it's copied#1005
Conversation
RossBencina
added
the
src-pulseaudio
|
Should this been reviewed. It's mainly just moving code. @kleinerm do you have time to test this? |
|
Looks ok modulo my comments. Let's wait another week for @kleinerm to show up (or not). |
illuusio
force-pushed
the
pulseaudio-fix-output-writing-place
branch
from
88257aa to
70f7042
Compare
Output copying what in incorrect place now that should be corrected
illuusio
force-pushed
the
pulseaudio-fix-output-writing-place
branch
from
70f7042 to
2e3b67b
Compare
|
Is this ok to merge? |
|
Could this be updated @RossBencina or @philburk so I can start working on other pr? |
RossBencina
left a comment
RossBencina
left a comment
There was a problem hiding this comment.
Fix indent. I will merge
| hostFramesPerBuffer ); | ||
| } | ||
|
|
||
| /* Is output is enable and buffer data is not NULL |
There was a problem hiding this comment.
This code does not check that "buffer data is not null".
| } | ||
|
|
||
| /* Is output is enable and buffer data is not NULL | ||
| * then crap pointer to output ringbuffer |
There was a problem hiding this comment.
What is a "crap pointer"?
|
Your code comments are difficult to understand for native English speakers. Maybe try using an AI to help with grammar. We're not really happy with the comments but will merge anyway so that you can move forward. |
Sorry about that. I'll use AI in future. |
3 participants
Output copying what in incorrect place now that should be corrected. This is related: #965