Skip to content

[cmake] Increase minimum required version of CMake to 3.5#1019

Merged
RossBencina merged 1 commit into
PortAudio:masterfrom
gruenich:feature/cmake-3.5
Apr 24, 2025
Merged

[cmake] Increase minimum required version of CMake to 3.5#1019
RossBencina merged 1 commit into
PortAudio:masterfrom
gruenich:feature/cmake-3.5

Conversation

@gruenich
Copy link
Copy Markdown
Contributor

@gruenich gruenich commented Apr 5, 2025

CMake 4 refuses to accept a minimum required version below 3.5 without additional flags.

CMake 4 refuses to accept a minimum required version
below 3.5 without additional flags.
@mortie
Copy link
Copy Markdown

mortie commented Apr 12, 2025

I'm hitting this as well, and it'll be a bigger and bigger problem as more and more systems start distributing cmake 4 by default. This MR fixes the issue.

Although the PortAudio project may want to consider whether it actually supports CMake 3.5, or if a higher number would be more appropriate.

@philburk
Copy link
Copy Markdown
Collaborator

@RossBencina - this seems like a reasonable step towards the evantual 3.10 patch. What do you think?

@RossBencina
Copy link
Copy Markdown
Collaborator

This PR (#1019) moves from CMake 3.1.0 -> 3.5, which is the minimum required version that CMake 4.0 will accept. Note that this PR still causes a deprecation warning, therefore does NOT address #1016.

With a view towards Docker images, using 3.5 maintains compatibility with Ubuntu LTS 16.04 (Xenial Xerus), which ships with CMake 3.5.1. Note that Ubuntu 14.04 shipped with 2.8.12 so we don't care about that.

For reference, PR #1013 is to require CMake 3.10 and there is more discussion there.

Copy link
Copy Markdown
Collaborator

@RossBencina RossBencina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the appropriate next step.

@RossBencina RossBencina merged commit ccd16c8 into PortAudio:master Apr 24, 2025
11 checks passed
@gruenich gruenich deleted the feature/cmake-3.5 branch October 8, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants