Skip to content

Add Windows ARM64 support in CI#1146

Open
Harishmcw wants to merge 1 commit into
PortAudio:masterfrom
Harishmcw:win_arm64
Open

Add Windows ARM64 support in CI#1146
Harishmcw wants to merge 1 commit into
PortAudio:masterfrom
Harishmcw:win_arm64

Conversation

@Harishmcw
Copy link
Copy Markdown

This PR adds Windows ARM64 support to the MSBuild and CMake CI workflows.

Changes:

  • CMake
    • Added Windows-MSVC-ARM64 and Windows-MinGW-ARM64 jobs.
    • Configured appropriate vcpkg triplets and generators.
    • Added conditional -A handling for MSVC ARM64 builds.
  • MSBuild
    • Added ARM64 platform configuration to portaudio.vcproj and portaudio.sln
    • Added ARM64 to the CI build matrix.

Comment thread .github/workflows/cmake.yml
Copy link
Copy Markdown
Collaborator

@RossBencina RossBencina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check that this wasn't going to create backward compatibility problems I opened the .sln solution in Visual Studio 2005. There were no obvious problems introduced by the presence of the ARM64 configuration (it would not build of course). The Win32 target seemed to build (modulo some unrelated errors that we should probably fix).

Could I get you to fix one more thing please? : When I opened the solution ARM64 was already the selected configuration. Could you make open with the 64-bit intel config please?

@Harishmcw
Copy link
Copy Markdown
Author

Hi @RossBencina,

After some investigation I found that on Visual Studio 2005, the default configuration is picked alphabetically, since ARM64 sorts before x64, it ends up selected by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants