Add request id to proxy history and a get_proxy_http_history_by_id tool - #111
Open
redteam10it wants to merge 1 commit into
Open
Add request id to proxy history and a get_proxy_http_history_by_id tool#111redteam10it wants to merge 1 commit into
redteam10it wants to merge 1 commit into
Conversation
Proxy HTTP history items can only be referenced by list offset, so an MCP client cannot point to a specific request the way a user does in Burp's UI (by its request number). This addresses PortSwigger#30. - Expose the Burp request id on serialized proxy history items (the number shown in Proxy > HTTP history). The field is nullable and omitted for request/responses that don't come from proxy history, so existing output is unchanged for those. - Add get_proxy_http_history_by_id, which returns a single history item by that id, with the same data-access permission check as the other history tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_proxy_http_historyonly addresses items by list offset, so there's no way to point at a specific request by the number Burp shows in Proxy > HTTP history. The usual workaround (offset = id - 1) falls apart as soon as the history is filtered or items are dropped.id(fromProxyHttpRequestResponse.id()). The field is nullable and omitted for request/responses that don't originate from proxy history (e.g. scanner issues), so their output is unchanged.get_proxy_http_history_by_idtool returns a single history item by that id, using the same data-access permission check as the other history tools.Closes #30.
Test plan
./gradlew testpassesid; an unknown id returns a not-found message