fix multi turn tool calling for anthropic when arguments to the tool call is an empty object #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…call is an empty object
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Summary By MatterAI
🔄 What Changed
🔍 Impact of the Change
📁 Total Files Changed
🧪 Test Added
🔒 Security Vulnerabilities
Type of Change
Checklist
Sequence DiagramsequenceDiagram
participant Client
participant AnthropicChatComplete
participant ToolCall
Client->>AnthropicChatComplete: Invoke chat completion
AnthropicChatComplete->>ToolCall: Process tool calls
Note over ToolCall: Check tool function arguments length
alt Arguments exist
ToolCall->>ToolCall: JSON.parse(arguments)
else No arguments
ToolCall->>ToolCall: Return empty object {}
end
AnthropicChatComplete-->>Client: Return processed tool calls
|
narengogi
changed the title
narengogi
requested review from
sabbyasachiRPortkey and
siddharthsambharia-portkey
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Summary By MatterAI
🔄 What Changed
🔍 Impact of the Change
📁 Total Files Changed
🧪 Test Added
🔒 Security Vulnerabilities
Type of Change
Checklist
Sequence DiagramsequenceDiagram
participant Anthropic as A
participant ToolCall as TC
participant ChatComplete as CC
A->>TC: Prepare Tool Call
TC-->>CC: Pass Tool Call Arguments
CC->>TC: Parse Arguments
Note over CC: Handle Empty Object Case
TC->>A: Return Processed Tool Call
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
$defsalongwith your schema#1103
Testing done
Did multi turn tool calling with empty string arguments in assistant tool call message
payload for testing
{ "model": "claude-3-5-sonnet-20240620", "max_tokens": 200, "stream": false, "messages": [ { "role": "user", "content": "Based on the temperature and time in California what do you suggest I wear?" }, { "role": "assistant", "content": "Certainly! I'd be happy to provide you with the current temperature and time in San Francisco. To get this information, I'll need to use two separate tools. Let me fetch that data for you.", "tool_calls": [ { "id": "toolu_01BspjPLY4dtHkKGurn8q9A6", "type": "function", "function": { "name": "get_current_temperature", "arguments": "" } }, { "id": "toolu_014jEfKqGbfFvRaKfiauxgPv", "type": "function", "function": { "name": "get_current_time", "arguments": "{\"location\":\"San Francisco, CA\"}" } } ] }, { "role": "tool", "content": "15 degrees", "tool_call_id": "toolu_01BspjPLY4dtHkKGurn8q9A6" }, { "role": "tool", "content": "10 PM", "tool_call_id": "toolu_014jEfKqGbfFvRaKfiauxgPv" } ], "tools": [ { "type": "function", "function": { "name": "get_current_temperature", "description": "Get the current temperature for a specific location", "parameters": { "type": "object", "properties": { "location": { "type": "string", "description": "The city and state, e.g., San Francisco, CA" }, "unit": { "type": "string", "enum": [ "Celsius", "Fahrenheit" ], "description": "The temperature unit to use. Infer this from the user's location." } }, "required": [ "location", "unit" ] } } }, { "type": "function", "function": { "name": "get_current_time", "description": "Get the current time for a specific location", "parameters": { "type": "object", "properties": { "location": { "type": "string", "description": "The city and state, e.g., San Francisco, CA" } }, "required": [ "location" ] } } } ] }