-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/return model in response #982
base: main
Are you sure you want to change the base?
Chore/return model in response #982
Conversation
@@ -148,7 +158,7 @@ export const OpenrouterChatCompleteStreamChunkTransform: ( | |||
if (chunk.includes('OPENROUTER PROCESSING')) { | |||
chunk = JSON.stringify({ | |||
id: `${Date.now()}`, | |||
model: '', | |||
model: gatewayRequest.model || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Openrouter now sends model in the response itself. We can use that directly.
@@ -207,7 +217,7 @@ export const TogetherAIChatCompleteStreamChunkTransform: ( | |||
id: parsedChunk.id, | |||
object: parsedChunk.object, | |||
created: Math.floor(Date.now() / 1000), | |||
model: '', | |||
model: gatewayRequest.model || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TogetherAI now sends model in the response itself. We can use it directly.
/matter summary |
I'm generating a summary for this PR. I'll post it shortly. |
Chore/return model in response🔄 What Changed
🔍 Impact of the Change
📁 Total Files Changed
🧪 Test Added
🔒 Security Vulnerabilities
|
/matter review |
I'm reviewing this PR now. I'll provide feedback shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good overall, but please consider adding unit tests to ensure the new functionality is covered.
/matter explain |
This Pull Request introduces several modifications primarily focused on enhancing the response handling for various AI providers by including the model in the responses. The changes span multiple files and involve both non-streaming and streaming response handlers.
Overall, this PR significantly enhances the response handling capabilities of the application by ensuring that the model information is consistently included across various AI providers, improving the traceability and accuracy of responses. |
Title:
Description:
🔄 What Changed
gatewayRequest
, which contains the model information.🔍 Impact of the Change
📁 Total Files Changed
🧪 Test Added
🔒 Security Vulnerabilities