feat(code): add PR diff source

[adboio]

Problem

local tasks may have associated PRs now, but there's no way to view the PR diff

Changes

adds PR as a diff source, little bit of refactoring along the way

How did you test this?

manually

[adboio]

• fix(code): fix branch vs default diff for unpushed changes #1874
• feat(code): add PR comments to local tasks #1868
• feat(code): use chosen diff source for badge #1865
• feat(code): add PR diff source #1864 👈 (View in Graphite)
• feat(code): add PR actions to local tasks #1862
• feat(code): add method for finding PR for branch #1861
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Prompt To Fix All With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/code-review/components/ReviewPage.tsx
Line: 38

Comment:
**Duplicate empty-array constant**

`EMPTY_PR_FILES` is structurally identical to `EMPTY_BRANCH_FILES` (both are `ChangedFile[]` initialized to `[]`). Per the OnceAndOnlyOnce simplicity rule, a single constant should serve both uses.

```suggestion
const EMPTY_CHANGED_FILES: ChangedFile[] = [];
```

Then replace both `EMPTY_BRANCH_FILES` and `EMPTY_PR_FILES` usages with `EMPTY_CHANGED_FILES`.

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: apps/code/src/renderer/features/code-review/utils/resolveDiffSource.test.ts
Line: 78-86

Comment:
**Missing branch fallback test case**

The previous suite included a case where `linkedBranch` is set but `aheadOfDefault` is `0` (branch exists but nothing has been committed ahead). That case was dropped when the test was updated and is no longer covered. The surviving "falls back to local when unavailable" case only exercises `linkedBranch: null`.

Consider adding:
```ts
{
  desc: "explicit branch falls back to local when no commits ahead",
  configured: "branch",
  hasLocalChanges: false,
  linkedBranch: "feat/x",
  aheadOfDefault: 0,
  prSourceAvailable: false,
  expected: "local",
},
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "feat(code): add PR diff source" | Re-trigger Greptile}

[greptile-apps]

Duplicate empty-array constant

EMPTY_PR_FILES is structurally identical to EMPTY_BRANCH_FILES (both are ChangedFile[] initialized to []). Per the OnceAndOnlyOnce simplicity rule, a single constant should serve both uses.

Suggested change

	const EMPTY_PR_FILES: ChangedFile[] = [];
	const EMPTY_CHANGED_FILES: ChangedFile[] = [];

Then replace both EMPTY_BRANCH_FILES and EMPTY_PR_FILES usages with EMPTY_CHANGED_FILES.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/code-review/components/ReviewPage.tsx
Line: 38

Comment:
**Duplicate empty-array constant**

`EMPTY_PR_FILES` is structurally identical to `EMPTY_BRANCH_FILES` (both are `ChangedFile[]` initialized to `[]`). Per the OnceAndOnlyOnce simplicity rule, a single constant should serve both uses.

```suggestion
const EMPTY_CHANGED_FILES: ChangedFile[] = [];
```

Then replace both `EMPTY_BRANCH_FILES` and `EMPTY_PR_FILES` usages with `EMPTY_CHANGED_FILES`.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

Missing branch fallback test case

The previous suite included a case where linkedBranch is set but aheadOfDefault is 0 (branch exists but nothing has been committed ahead). That case was dropped when the test was updated and is no longer covered. The surviving "falls back to local when unavailable" case only exercises linkedBranch: null.

Consider adding:

{
  desc: "explicit branch falls back to local when no commits ahead",
  configured: "branch",
  hasLocalChanges: false,
  linkedBranch: "feat/x",
  aheadOfDefault: 0,
  prSourceAvailable: false,
  expected: "local",
},

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/code-review/utils/resolveDiffSource.test.ts
Line: 78-86

Comment:
**Missing branch fallback test case**

The previous suite included a case where `linkedBranch` is set but `aheadOfDefault` is `0` (branch exists but nothing has been committed ahead). That case was dropped when the test was updated and is no longer covered. The surviving "falls back to local when unavailable" case only exercises `linkedBranch: null`.

Consider adding:
```ts
{
  desc: "explicit branch falls back to local when no commits ahead",
  configured: "branch",
  hasLocalChanges: false,
  linkedBranch: "feat/x",
  aheadOfDefault: 0,
  prSourceAvailable: false,
  expected: "local",
},
```

How can I resolve this? If you propose a fix, please make it concise.

[adboio]

Merge activity

• Apr 27, 3:56 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 27, 3:57 PM UTC: @adboio merged this pull request with Graphite.