fix(code): preserve session scroll position across window focus#1886
Merged
Conversation
The visibilitychange handler in ConversationView unconditionally scrolled the conversation to the bottom whenever the document became visible again, so cmd+tab away and back would always destroy the user's reading position. Gate the scroll on the same at-bottom state already reported by VirtualizedList, so we only re-pin to the bottom when the user was already following the stream. Manual scroll positions now survive focus changes. Generated-By: PostHog Code Task-Id: 2297f0c5-16fb-475d-8a2b-13cbcae500dd
Contributor
|
Reviews (1): Last reviewed commit: "fix(code): preserve session scroll posit..." | Re-trigger Greptile |
jonathanlab
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibilitychangehandler inConversationView.tsxwas callingscrollToBottom()unconditionally whenever the document became visible — so cmd+tab away and back always reset the user's scroll position.VirtualizedListinto a ref and only re-pin to the bottom on visibility return when the user was already following the stream. Manual scroll positions are now preserved across focus changes; streaming auto-scroll continues to work because it has its own at-bottom check.Test plan
pnpm --filter code typecheckpnpm --filter code test(947 pass; one unrelatedarchive/service.integration.test.ts > unarchive with recreateBranchtimeout in main-process git code)