Relax worker session operation admission#750
Closed
bill-ph wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the worker session operation model from hard admission control to safety-by-convention at the protocol layer. Pgwire clients do not have a happy-path way to run concurrent user queries on a single connection, but the control plane can still produce brief worker Flight RPC overlap during normal serial flows, especially Describe/GetFlightInfo cleanup followed by Execute. Treating that overlap as an active user operation caused false FailedPrecondition failures.
The worker now keeps the mechanical safety where it matters: connMu serializes actual sql.Conn / sql.Tx access, connWork fences teardown and reapers, and drain tokens still track pending continuations for graceful shutdown. Pending Flight continuations no longer make the session globally busy.
Changes
Verification