Skip to content

chore: validate PR titles with conventional commits#121

Merged
dustinbyrne merged 2 commits into
mainfrom
chore/validate-pr-title-conventional-commits
May 27, 2026
Merged

chore: validate PR titles with conventional commits#121
dustinbyrne merged 2 commits into
mainfrom
chore/validate-pr-title-conventional-commits

Conversation

@dustinbyrne

Copy link
Copy Markdown
Contributor

💡 Motivation and Context

Our changelog automation uses merged PR titles to determine changelog candidates/entries. Enforcing Conventional Commit PR titles across SDK repos keeps titles structured and easier to classify consistently.

💚 How did you test it?

  • Parsed the new workflow YAML locally with PyYAML.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • No changeset/Sampo entry needed for this CI-only change.

@dustinbyrne dustinbyrne requested review from a team and rafaeelaudibert as code owners May 27, 2026 16:33
@greptile-apps

greptile-apps Bot commented May 27, 2026

Copy link
Copy Markdown
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/workflows/lint-pr.yml:5-8
The `reopened` event type is missing. If a PR is closed while the lint check is in a failed state and then reopened, the workflow won't re-run and the stale failure will block merging until the PR is edited or a new commit is pushed. Adding `reopened` is recommended in the action's own documentation for this reason.

```suggestion
    types:
      - opened
      - edited
      - synchronize
      - reopened
```

Reviews (1): Last reviewed commit: "chore: validate PR titles with conventio..." | Re-trigger Greptile

Comment thread .github/workflows/lint-pr.yml
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

posthog-elixir Compliance Report

Date: 2026-05-27 16:40:25 UTC
Duration: 107379ms

⚠️ Some Tests Failed

42/45 tests passed, 3 failed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 610ms
Format Validation.Event Has Uuid 611ms
Format Validation.Event Has Lib Properties 610ms
Format Validation.Distinct Id Is String 610ms
Format Validation.Token Is Present 611ms
Format Validation.Custom Properties Preserved 614ms
Format Validation.Event Has Timestamp 611ms
Retry Behavior.Retries On 503 5616ms
Retry Behavior.Does Not Retry On 400 2613ms
Retry Behavior.Does Not Retry On 401 2612ms
Retry Behavior.Respects Retry After Header 5615ms
Retry Behavior.Implements Backoff 15619ms
Retry Behavior.Retries On 500 5611ms
Retry Behavior.Retries On 502 5617ms
Retry Behavior.Retries On 504 5617ms
Retry Behavior.Max Retries Respected 15626ms
Deduplication.Generates Unique Uuids 621ms
Deduplication.Preserves Uuid On Retry 5614ms
Deduplication.Preserves Uuid And Timestamp On Retry 10621ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 5618ms
Deduplication.No Duplicate Events In Batch 616ms
Deduplication.Different Events Have Different Uuids 614ms
Compression.Sends Gzip When Enabled 610ms
Batch Format.Uses Proper Batch Structure 610ms
Batch Format.Flush With No Events Sends Nothing 607ms
Batch Format.Multiple Events Batched Together 616ms
Error Handling.Does Not Retry On 403 2612ms
Error Handling.Does Not Retry On 413 2613ms
Error Handling.Retries On 408 5613ms

Feature_Flags Tests

⚠️ 13/16 tests passed, 3 failed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 9ms
Request Payload.Flags Request Uses V2 Query Param 6ms
Request Payload.Flags Request Hits Flags Path Not Decide 7ms
Request Payload.Flags Request Omits Authorization Header 7ms
Request Payload.Token In Flags Body Matches Init 8ms
Request Payload.Groups Round Trip 7ms
Request Payload.Groups Default To Empty Object 7ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It 8ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 7ms
Request Payload.Disable Geoip Omitted Defaults To False 7ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 7ms
Request Lifecycle.No Flags Request On Init Alone 4ms
Request Lifecycle.No Flags Request On Normal Capture 608ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 12ms
Request Lifecycle.Mock Response Value Is Returned To Caller 6ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 611ms

Failures

request_payload.disable_geoip_omitted_defaults_to_false

Field 'geoip_disable' not found in /flags request body at path 'geoip_disable'. Available keys: ['groups', 'api_key', 'distinct_id', 'flag_keys_to_evaluate', 'group_properties', 'person_properties']

request_lifecycle.mock_response_value_is_returned_to_caller

Last action result missing field 'value'. Keys: ['error', 'success']

side_effect_events.get_feature_flag_captures_feature_flag_called_event

Expected 1 events with name '$feature_flag_called', got 0

@dustinbyrne dustinbyrne enabled auto-merge (squash) May 27, 2026 16:51

@rafaeelaudibert rafaeelaudibert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a shared action on .github and we add it to every single PR? This will make this much easier to track/follow/update/keep consistent

@dustinbyrne dustinbyrne merged commit a9327dd into main May 27, 2026
21 checks passed
@dustinbyrne dustinbyrne deleted the chore/validate-pr-title-conventional-commits branch May 27, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants