feat: add base survey integration #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # Makefile # PostHog.podspec # PostHog.xcodeproj/project.pbxproj # PostHog/PostHogApi.swift # PostHog/PostHogSDK.swift # PostHog/PostHogVersion.swift # PostHogTests/PostHogFeatureFlagsTest.swift # PostHogTests/PostHogSessionManagerTest.swift # PostHogTests/TestUtils/MockApplicationLifecyclePublisher.swift # PostHogTests/TestUtils/TestPostHog.swift
ioannisj
commented
Mar 10, 2025
| @@ -59,11 +59,11 @@ import Foundation | |||
| @objc public let sessionReplayConfig: PostHogSessionReplayConfig = .init() | |||
| #endif | |||
|
|
|||
| #if os(iOS) | |||
| #if os(iOS) || TESTING | |||
There was a problem hiding this comment.
Public api is still draft here. Just added TESTING so that tests can run on CI as well for now
| #else | ||
| properties["$is_emulator"] = false | ||
| #endif | ||
| if let deviceType = PostHogContext.deviceType { |
There was a problem hiding this comment.
Had to extract deviceType logic here since it was needed for surveys as well. Cleaned up/refactored a bit PostHogContext
| @@ -37,7 +37,7 @@ let maxRetryDelay = 30.0 | |||
|
|
|||
| private var queue: PostHogQueue? | |||
| private var replayQueue: PostHogQueue? | |||
| private var storage: PostHogStorage? | |||
| private(set) var storage: PostHogStorage? | |||
There was a problem hiding this comment.
Changed to internal visibility since it will be used by surveys to check survey seen info
| return postHog.isFeatureEnabled(flagKey) | ||
| } | ||
|
|
||
| private func canRenderSurvey(survey _: Survey) -> Bool { |
There was a problem hiding this comment.
Temp. Not called yet
Comment on lines
+250
to
+269
| private func setActiveSurvey(survey: Survey) { | ||
| activeSurveyLock.withLock { | ||
| if let activeSurvey { | ||
| hedgeLog("Survey \(activeSurvey) already in focus. Cannot add survey \(survey).") | ||
| return | ||
| } | ||
| activeSurvey = survey | ||
| } | ||
| } | ||
|
|
||
| /// Removes given survey as active survey | ||
| private func removeActiveSurvey(survey: Survey) { | ||
| activeSurveyLock.withLock { | ||
| guard activeSurvey?.id != survey.id else { | ||
| hedgeLog("Survey \(survey) is not in focus. Cannot remove survey \(survey)") | ||
| return | ||
| } | ||
| activeSurvey = nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Temp. Not called yet
| return matchType.matches(targets: deviceTypes, value: deviceType) | ||
| } | ||
|
|
||
| private func getNextSurveyStep( |
There was a problem hiding this comment.
Temp. Not called yet
ioannisj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Added base logic for survey integration, including flag-based/internal targeting and device type checks for display conditions.
Added some draft/test implementation on presentation logic.
No event trigger handling yet—considering a simple
surveyIntegration.onEventCaptured()call for now. Ideally, though, internal delegates or handlers could provide better decoupling and would also enable us exposing these to the public API in the near future, something which is already requested herePublic API is still draft
#skip-changelog
TODO:
- user inputs are masked
- surveys are captured
💚 How did you test it?
Unit tests
📝 Checklist