Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage not working on tvOS #316

Merged
merged 6 commits into from
Mar 13, 2025
Merged

fix: storage not working on tvOS #316

merged 6 commits into from
Mar 13, 2025

Conversation

ioannisj
Copy link
Contributor

@ioannisj ioannisj commented Mar 12, 2025

💡 Motivation and Context

Closes #315

Local storage support on tvOS is limited, so we cannot use Application Support directory for storage.
Unfortunately, the permission error is only visible when running on a physical device and not on simulators.

This fix does the following:

  • Use Library/Caches for file queues
  • Use lower defaults on tvOS for some SDK configs like flushAt to lower the chances of missing events

tvOS only, other platforms should not be affected

💚 How did you test it?

Hasn't been fully tested since I don't have access to a physical device, but the user who reported this verified that switching to Library/Caches fixed the issue.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@ioannisj ioannisj requested a review from marandaneto as a code owner March 12, 2025 11:32
@ioannisj ioannisj requested a review from a team March 12, 2025 11:32
Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few suggestions and one point to discuss otherwise LGTM

@ioannisj ioannisj merged commit e874c5b into main Mar 13, 2025
7 checks passed
@ioannisj ioannisj deleted the fix/tv-os-storage branch March 13, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple TV support is broken
2 participants