Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: is_identified fallback value #317

Merged
merged 2 commits into from
Mar 13, 2025
Merged

fix: is_identified fallback value #317

merged 2 commits into from
Mar 13, 2025

Conversation

ioannisj
Copy link
Contributor

💡 Motivation and Context

Spotted this while going through code for a ticket. Checked android implementation which seems to be doing the right thing

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@ioannisj ioannisj requested a review from marandaneto as a code owner March 13, 2025 06:20
@ioannisj ioannisj requested a review from a team March 13, 2025 06:21
marandaneto
marandaneto approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, Should we add a test for it?

@ioannisj
Copy link
Contributor Author

Lgtm, Should we add a test for it?

yeap, added a simple test

@ioannisj ioannisj merged commit 8cac126 into main Mar 13, 2025
6 checks passed
@ioannisj ioannisj deleted the fix/is-identified-fallback-value branch March 13, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioannisj @marandaneto