feat: injectable logging instead of printing #62
Conversation
| private final Logger logger; | ||
|
|
||
| public DefaultPostHogLogger() { | ||
| this.logger = Logger.getLogger(PostHog.class.getName()); |
There was a problem hiding this comment.
technically a breaking change if people were relying on console output, but much nicer IMHO
There was a problem hiding this comment.
I can see someone's tests relying on asserting our library's error. Any reason why we need to add this? What's your follow-up? :)
@rafaeelaudibert always better to comment on a random file, so we can thread.
it's the literal worse feature of github
There was a problem hiding this comment.
i think if this wasn't marked as "this my break" in the README I'd be more careful here
but for a backend SDK this random throwing and logging is pretty messy tbh
There was a problem hiding this comment.
sorry, not random throwing either... swallowing of errors and logging randomly
There was a problem hiding this comment.
always better to comment on a random file, so we can thread
yeah, lol, sorry
i think if this wasn't marked as "this my break" in the README I'd be more careful here
Ah, that's reasonable, I didn't see that, makes me more comfortable as well :)
There was a problem hiding this comment.
CI isn't passing, but approving, code makes sense, even though I'm not sure logger.error will look similar to what e.printStackTrace() was doing before.
Yep, I think it will work better for people 🤞
There was a problem hiding this comment.
You really hate GH's behavior right
There was a problem hiding this comment.
it's even worse cos i have to admit @benjackwhite was right again :p
There was a problem hiding this comment.
I WAS RIGHT!!!
...what was I right about?
|
ugh... i need to install intellij to make this work properly :/ |
| if (this.logger == null) { | ||
| this.logger = new DefaultPostHogLogger(); | ||
| } |
There was a problem hiding this comment.
| if (this.logger == null) { | |
| this.logger = new DefaultPostHogLogger(); | |
| } | |
| if (logger == null) { | |
| logger = new DefaultPostHogLogger(); | |
| } |
there are no 2 logger vars in this context to use this
There was a problem hiding this comment.
ooh I didn't know you could omit the this like that, nice
made me realise I could just init the logger in the base class anyway
| if (this.logger == null) { | ||
| this.logger = new DefaultPostHogLogger(); | ||
| } |
There was a problem hiding this comment.
| import java.util.logging.Level; | ||
| import java.util.logging.Logger; | ||
|
|
||
| public class DefaultPostHogLogger implements PostHogLogger { |
There was a problem hiding this comment.
could probably use https://docs.oracle.com/javase/8/docs/api/java/util/logging/Logger.html but having PostHog logger is also fine
There was a problem hiding this comment.
yep, I'm far enough away from java ecosystem that I thought if we have an interface then folk can use just about whatever they want and avoid coupling ourselves to something only for people to say "but why not OmniLogger.io"
We print to the console with no way to override that.
Let's give people a way to edit the logging
See: https://posthoghelp.zendesk.com/agent/tickets/22819